Skip to content
This repository has been archived by the owner on Mar 13, 2018. It is now read-only.

Support for absolute bower URLs #289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sfeederle
Copy link

If bower dependencys are saved as URLs (https://bower.io/#install-packages) instead of Github shorthands the Source link in the UI breaks.
This is because 'https://github.com/' is always appanded to the front of the source, even if its already a hyperlink.

This fix enables URLs in bower dependencies, even to private github enterprise servers like:

"dependencies": {
    "my-element": "https://github.customdomain.com/elements/my-element.git#^1.0.0"
}

If bower dependencys are saved as URLs (https://bower.io/#install-packages) the <sources> link in the UI breaks.
This is because 'https://github.com/' is always appanded to the front of the source, even if its already a hyperlink.

This fix enables URLs in bower dependencies, even to private github enterprise servers like: 
"my-element": "https://github.customdomain.com/elements/my-element.git#^1.0.0"
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants