Set timeout duration as optional argument #4050
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
github-actions
bot
added
kind/cleanup
AndreasWintherMoen
force-pushed
the
optional-timeout
branch
from
23c2069 to
4f3ac39
Compare
|
Fixed CLA. Not sure what other failing check is caused by. |
|
/gcbrun |
|
Build Succeeded 🥳 Build Id: 9c564924-79d7-4619-8422-2c072a84f252 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
Hi @AndreasWintherMoen , thanks for contribution! Would you mind add some description to the doc here for the change? Thanks! |
|
/gcbrun |
|
Build Succeeded 🥳 Build Id: f72c2663-8efe-4435-bbce-6c5f3c25ceb3 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
/gcbrun |
|
Build Failed 😭 Build Id: 3a01af20-2153-44ab-be27-c1d4a3b83af3 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
| @@ -82,8 +82,8 @@ var agones = agonesGameObject.GetComponent<Agones.AgonesSdk>(); | |||
| ``` | |||
|
|
|||
| To connect to the SDK server, either local or when running on Agones, run the async `Connect()` method. | |||
| This will wait for up to 30 seconds if the SDK server has not yet started and the connection cannot be made, | |||
| and will return `false` if there was an issue connecting. | |||
| By default, this will wait for up to 30 seconds if the SDK server has not yet started and the connection cannot be made. You can specify an optional timeout duration argument to the method, e.g., Connect(60) for a 60-second timeout. | |||
There was a problem hiding this comment.
Should add feature expiry around the deleted lines, and publish version around the new lines.
{{% feature expiryVersion="1.46.0" %}}
{{% /feature %}}
publish='{{% feature publishVersion="1.46.0" %}}'
{{% /feature %}}
|
Super late to the party on this PR, but I'll ask the question: why? 😄 we've used 30s everywhere else, seems strange to deviate in one place without a pretty strong reason. |
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Just a small change to add an optional timeoutSeconds argument instead of a hard-coded value in Connect method in Unity SDK. This allows users to set a custom timeout duration if they have a very specific setup that requires it. The default timeout is 30 seconds to ensure backward compatibility.