chore: share only incrementing errors if not a filter packet drops be…

…tween XDP and io-uring (#1103)

src/components/proxy/error.rs

@@ -25,6 +25,22 @@ pub enum PipelineError {
 }
 
 impl PipelineError {
+    /// We only want to mark potential I/O errors as errors, as they
+    /// can indicate something wrong with the system, error variants
+    /// from packets being bad aren't errors from quilkin's perspective.
+    pub(crate) fn inc_system_errors_total(
+        &self,
+        direction: crate::metrics::Direction,
+        asn_info: &crate::metrics::AsnInfo,
+    ) {
+        if matches!(
+            self,
+            PipelineError::Io(_) | PipelineError::Filter(crate::filters::FilterError::Io(_))
+        ) {
+            crate::metrics::errors_total(direction, &self.to_string(), asn_info).inc();
+        }
+    }
+
     pub fn discriminant(&self) -> &'static str {
         match self {
             Self::NoUpstreamEndpoints => "no upstream endpoints",

src/components/proxy/packet_router.rs

@@ -85,15 +85,7 @@ impl<P: PacketMut> DownstreamPacket<P> {
         if let Err(error) = self.process_inner(config, sessions, destinations) {
             let discriminant = error.discriminant();
 
-            // We only want to mark potential I/O errors as errors, as they
-            // can indicate something wrong with the system, error variants
-            // from packets being bad aren't errors from quilkin's perspective.
-            if matches!(
-                error,
-                PipelineError::Io(_) | PipelineError::Filter(crate::filters::FilterError::Io(_))
-            ) {
-                metrics::errors_total(metrics::READ, discriminant, &metrics::EMPTY).inc();
-            }
+            error.inc_system_errors_total(metrics::READ, &metrics::EMPTY);
             metrics::packets_dropped_total(metrics::READ, discriminant, &metrics::EMPTY).inc();
         }
 

src/net/xdp/process.rs

@@ -391,7 +391,7 @@ pub fn process_packets(
             }
             Err((error, packet)) => {
                 let discriminant = error.discriminant();
-                metrics::errors_total(direction, discriminant, &metrics::EMPTY).inc();
+                error.inc_system_errors_total(direction, &metrics::EMPTY);
                 metrics::packets_dropped_total(direction, discriminant, &metrics::EMPTY).inc();
 
                 umem.free_packet(packet);