[bugfix] Do not abort saving if the OTP counter is aborted (#2775)

Fixes #2763

Signed-off-by: Dominik Schulz <[email protected]>

internal/action/otp.go

@@ -111,6 +111,7 @@ func (s *Action) otp(ctx context.Context, name, qrf string, clip, pw, recurse bo
 		return s.otpHandleError(ctx, name, qrf, clip, pw, recurse, err)
 	}
 
+	outerCtx := ctx
 	ctx = config.WithMount(ctx, s.Store.MountPoint(name))
 	ctx, cancel := context.WithCancel(ctx)
 	defer cancel()
@@ -164,8 +165,9 @@ func (s *Action) otp(ctx context.Context, name, qrf string, clip, pw, recurse bo
 			}
 			counter++
 			_ = sec.Set("counter", strconv.Itoa(int(counter)))
-			if err := s.Store.Set(ctx, name, sec); err != nil {
-				out.Errorf(ctx, "Failed to persist counter value: %s", err)
+			// using outerCtx here because we want to save the counter even if the user cancels.
+			if err := s.Store.Set(outerCtx, name, sec); err != nil {
+				out.Errorf(outerCtx, "Failed to persist counter value: %s", err)
 			}
 			debug.Log("Saved counter as %d", counter)
 		}