Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUT-3754: Make blocking code async #2368

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Conversation

ethanmills
Copy link
Member

@ethanmills ethanmills commented Nov 27, 2024

Per https://github.com/govuk-one-login/architecture/blob/913c04af8b57e2cdce07c4b242a409690852d527/rfc/0083-express-on-ecs.md#too-many-connections, this makes some blocking calls async

  • nonce generation
  • session ID generation

Both "inspired" by changes in ipv-core-front.

This has been tested in sandpit

@ethanmills ethanmills force-pushed the AUT-3754/remove-blocking-code branch 4 times, most recently from bb9288a to 74df0ed Compare November 29, 2024 13:23
@ethanmills ethanmills force-pushed the AUT-3754/remove-blocking-code branch from 74df0ed to 51de6aa Compare December 12, 2024 12:56
@ethanmills ethanmills marked this pull request as ready for review December 17, 2024 11:21
@ethanmills ethanmills requested review from a team as code owners December 17, 2024 11:21
@ethanmills ethanmills force-pushed the AUT-3754/remove-blocking-code branch from 51de6aa to ec42ac1 Compare February 4, 2025 13:52
dbes-gds
dbes-gds previously approved these changes Feb 11, 2025
@ethanmills ethanmills force-pushed the AUT-3754/remove-blocking-code branch 2 times, most recently from 9cc2aeb to aabfad9 Compare February 20, 2025 10:41
dbes-gds
dbes-gds previously approved these changes Feb 20, 2025
@dbes-gds dbes-gds self-requested a review February 20, 2025 11:24
- nonce generation
- session ID generation

Both "inspired" by changes in ipv-core-front
@ethanmills ethanmills merged commit 008faac into main Feb 20, 2025
9 checks passed
@ethanmills ethanmills deleted the AUT-3754/remove-blocking-code branch February 20, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants