-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AUT-3754: Make blocking code async #2368
Merged
Merged
+42
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bb9288a
to
74df0ed
Compare
74df0ed
to
51de6aa
Compare
|
51de6aa
to
ec42ac1
Compare
ethanmills
commented
Feb 4, 2025
ec42ac1
to
b791629
Compare
dbes-gds
previously approved these changes
Feb 11, 2025
9cc2aeb
to
aabfad9
Compare
dbes-gds
previously approved these changes
Feb 20, 2025
- nonce generation - session ID generation Both "inspired" by changes in ipv-core-front
aabfad9
to
c7097c2
Compare
|
dbes-gds
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://github.com/govuk-one-login/architecture/blob/913c04af8b57e2cdce07c4b242a409690852d527/rfc/0083-express-on-ecs.md#too-many-connections, this makes some blocking calls async
Both "inspired" by changes in ipv-core-front.
This has been tested in sandpit