LIME-906 Correct Invalid HTTPRetryer exceptions and adjust DVLA timeout values to account for 2 endpoints with 1 retry each #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut values to account for 2 endpoints with 1 retry each
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
What changed
Correct the IOException type that HttpRetryer will retry to match the ones thrown by the http client used.
Why did it change
The HttpRetryer has the HttpConnectTimeoutException set as a retry condition this exception is not thrown by the HTTP client.
This has been change to allow retrying a ConnectTimeoutException or SocketTimeoutException.
For DVLA the retry has been lowered to 1 per endpoint (token/match)
The timeout values have been adjusted to be within the lambda timeout period but to allow the worst case of 1 retry for each endpoint with a slow but successful response on the retry.
Issue tracking