Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OJ-1495: Add SonarCloud workflows #813

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

CharlesIC
Copy link
Contributor

@CharlesIC CharlesIC commented Jan 18, 2024

⚠️ govuk-one-login/github-actions#13 needs to be merged first

Add a SonarCloud workflow.
Generate a test coverage report and submit it to SonarCloud.

Modularise GitHub workflows and use shared actions Use shared actions to reduce duplication and boilerplate. Apply standard GitHub Actions patterns from other repos.
Screenshot 2024-01-18 at 10 17 26

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@CharlesIC CharlesIC marked this pull request as ready for review January 18, 2024 11:31
@CharlesIC CharlesIC requested review from a team as code owners January 18, 2024 11:31
@CharlesIC CharlesIC marked this pull request as draft January 18, 2024 11:47
Add a SonarCloud workflow.
Generate a test coverage report and submit it to SonarCloud.

Modularise GitHub workflows and use shared actions
Use shared actions to reduce duplication and boilerplate.
Apply standard GitHub Actions patterns from other repos.
@CharlesIC CharlesIC force-pushed the oj-1495-sonarcloud-workflows branch from acaa4ad to 79f3337 Compare January 18, 2024 12:52
@CharlesIC CharlesIC marked this pull request as ready for review January 18, 2024 13:02
@CharlesIC CharlesIC merged commit ec09e07 into main Jan 25, 2024
8 checks passed
@CharlesIC CharlesIC deleted the oj-1495-sonarcloud-workflows branch January 25, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants