Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCMAW-82345 create activeSession APIgw alarms #387

Merged
merged 3 commits into from
Feb 10, 2025
Merged

DCMAW-82345 create activeSession APIgw alarms #387

merged 3 commits into from
Feb 10, 2025

Conversation

sandymay-dd
Copy link
Contributor

@sandymay-dd sandymay-dd commented Feb 10, 2025

DCMAW-8234

What changed

A low and high threshold alarm on both the 4XX and 5XX GET /async/activeSession endpoint

Testing

4XX: Invoked the endpoint with a badly formed request which results in a 4XX response.
image
5XX: Deployed a stack updating lambda handler typescript to return a 500.
image

How to review

A static check that the alarm configuration matches the requirements in the ticket.
Review the warning runbooks: https://govukverify.atlassian.net/wiki/spaces/DCMAW/pages/4800446694/Alarms+Runbook+Warnings
Review the critical runbooks: https://govukverify.atlassian.net/wiki/spaces/DCMAW/pages/4799594677/Alarms+Runbook+Alerts+-+DRAFT

Checklists

  • There is a ticket raised for this PR that is present in the branch name
  • No PII data logged. See guidance here
  • Demo to a BA, TA, and the team.
  • Update README with any new instructions or tasks

@sandymay-dd sandymay-dd marked this pull request as ready for review February 10, 2025 11:40
@sandymay-dd sandymay-dd requested review from a team as code owners February 10, 2025 11:40
@sandymay-dd sandymay-dd merged commit 1ed64ed into main Feb 10, 2025
2 checks passed
@sandymay-dd sandymay-dd deleted the DCMAW-8234 branch February 10, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants