-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure row numbers functionality in dataframe works as expected #10490
base: main
Are you sure you want to change the base?
Conversation
- tidy up header col spacing - change sort icon
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/74655791ea67f4901fd887e659a5317e5af5231f/gradio-5.14.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@74655791ea67f4901fd887e659a5317e5af5231f#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/74655791ea67f4901fd887e659a5317e5af5231f/gradio-client-1.10.0.tgz Use Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/74655791ea67f4901fd887e659a5317e5af5231f/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
Thanks @hannahblair, this looks great to me! A couple of nits, I'll note below, but which are non-blocking. I'm also cc-ing @hysts for his review |
- add corresponding colour for sort direction
@abidlabs I've removed the fixed width on the row number header and I've also changed the sort icon to have corresponding up and down coloured arrows. Let me know if that looks good to you! |
Thanks @hannahblair! Yes, the updates look great! Still have a couple of minor suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks @hannahblair
+1 for both two points @abidlabs mentioned above.
Also, regarding the second point, would it be possible to split the sort icon into two separate icons? I've always found it a bit inconvenient to have to press the arrow icon twice to sort in descending order. It would be more convenient if pressing the up arrow sorted in ascending order, pressing the down arrow sorted in descending order, and pressing the currently selected button again reverted to the original order.
Description
This PR:
show_row_numbers
param which seemed to get lost in a mergeCloses: #10411
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Testing and Formatting Your Code
PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests:
bash scripts/run_backend_tests.sh
Please run these bash scripts to automatically format your code:
bash scripts/format_backend.sh
, and (if you made any changes to non-Python files)bash scripts/format_frontend.sh