Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update backport workflow to use default GITHUB_TOKEN #7050

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jdbaldry
Copy link
Member

@jdbaldry jdbaldry commented Sep 27, 2024

Use the default token injected into workflows since the GH_BOT_ACCESS_TOKEN is revoked.

The default token doesn't have the permission used for unassigning default reviewers. If you don't have it, you get cryptic comments posted back on the PR after the backport PRs are opened with the message Validation Failed: "Could not resolve to a node with the global id of '<NODE ID>."

Like in grafana/pyroscope#3557 (comment)

Behavior was documented in grafana/grafana-github-actions#226 and made configurable in grafana/grafana-github-actions#227

removeDefaultReviewers: false instructs the workflow to not try to avoid the error but will of course not remove the default reviewers assigned on the backport PR.

The default token also cannot trigger CI so required checks will have to manually triggered with a commit not from this token. There are plans to provide this behavior as a shared workflow in https://github.com/grafana/shared-workflows but it may be some weeks before this is available.

Use the default token injected into workflows since the GH_BOT_ACCESS_TOKEN is revoked.

The default token doesn't have the permission used for unassigning default reviewers. If you don't have it, you get cryptic comments posted back on the PR after the backport PRs are opened with the message `Validation Failed: "Could not resolve to a node with the global id of '<NODE ID>."`

Like in grafana/pyroscope#3557 (comment)

Behavior was documented in grafana/grafana-github-actions#226 and made configurable in 
grafana/grafana-github-actions#227

`removeDefaultReviewers: false` instructs the workflow to not try to avoid the error but will of course not remove the default reviewers assigned on the backport PR.
Copy link
Contributor

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@github-actions github-actions bot added the needs-attention An issue or PR has been sitting around and needs attention. label Oct 28, 2024
@github-actions github-actions bot removed the needs-attention An issue or PR has been sitting around and needs attention. label Jan 15, 2025
@@ -14,14 +14,13 @@ jobs:
with:
repository: "grafana/grafana-github-actions"
path: ./actions
# Pin the version to before https://github.com/grafana/grafana-github-actions/pull/113 because
# to avoid the strict rules for PR labels.
ref: d284afd314ca3625c23595e9f62b52d215ead7ce
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to refer to a version, so that we have to update the workflow explicitly when new functionality is available? I suppose that now it'll just pull the latest from main?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants