Fix a flaky unit test in loki.process #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thampiotr
approved these changes
Sep 2, 2024
ptodev
force-pushed
the
ptodev/fix-flaky-loki-test
branch
from
0c0a49f to
5225524
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a genuine bug in the code which is causing a test to be flaky. However, I'm not classifying this PR as a bugfix because in practice the bug shouldn't cause issues for Alloy users. The leak would only happen when
Runcompletes, which can only happen once for the lifetime of the process - when the process exits. This fix was ported to Agent as well.