improvement: Go mod webdevops/go-common version bump. #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dtrejod thoughts on adding some documentation for the env vars? |
|
The Env Vars topic is here: https://grafana.com/docs/alloy/latest/reference/cli/environment-variables/ It'd be super helpful to add these new vars to this topic |
|
I can look to add docs. Let me throw a dev build on an environment to see exactly the full set of endpoints one needs to specify in the AZURE_CLOUD config envvar to get basic azure secret cloud metric collection working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR updates to the latest commit webdevops/go-common which importantly contains the following PR: webdevops/go-common#7.
Now a user can set
AZURE_ENVIRONMENT: AzureSecretCloudand provide a correspondingAZURE_CLOUD_CONFIG: <JSON>orAZURE_CLOUD_CONFIG_FILE: /path/to/filewith Azure secret cloud endpoints to have grafana-agent gather metrics from azure secret cloud regions.Which issue(s) this PR fixes
Notes to the Reviewer
Do we want changelogs for a go mod bump?
PR Checklist