Update wal doc #1917
Open
Update wal doc #1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdurham
commented
Oct 17, 2024
| `parallelism` | `uint` | How many parallel batches to write. | 10 | no | ||
| `external_labels` | `map(string)` | Labels to add to metrics sent over the network. | | no | ||
| Name | Type | Description | Default | Required | ||
| ----------------------|------------------------------------------------------|-----------------------------------------------------------------|---------|---------- |
There was a problem hiding this comment.
Functional change here is using the word long in retry_backoff and flush_interval
4 tasks
| `url` | `string` | Full URL to send metrics to. | | yes | ||
| `write_timeout` | `duration` | Timeout for requests made to the URL. | `"30s"` | no | ||
| `retry_backoff` | `duration` | How long to wait between retries. | `1s` | no | ||
| `max_retry_attempts` | Maximum number of retries before dropping the batch. | `0` | no |
There was a problem hiding this comment.
Missing the type here.
clayton-cornell
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update WAL doc and importantly remove reference to password_file since we dont support it, it should be handled by
local.fileor other functionality.