Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly end goroutine in benchmark #1932

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vladopajic
Copy link

PR Description

For loop used in the benchmark to discard messages was not properly terminated.

for {
	<-mbx.ReceiveC()
}
// <---- this is unreachable code

This loop will keep iterating because result from ReceiveC() was never checked.

Change in second for loop is more of cosmetic purposes, I hope you don't mind that.

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@vladopajic vladopajic requested a review from a team as a code owner October 20, 2024 12:24
@CLAassistant
Copy link

CLAassistant commented Oct 20, 2024

CLA assistant check
All committers have signed the CLA.

@vladopajic vladopajic changed the title fixed go leak in benchmark fix: properly end goroutine in benchmark Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants