Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple replicas to be configured via helm chart #328

Closed
josh-ferrell opened this issue Nov 2, 2023 · 4 comments
Closed

Allow multiple replicas to be configured via helm chart #328

josh-ferrell opened this issue Nov 2, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@josh-ferrell
Copy link
Contributor

Feature Description

Allow multiple manager replicas to be configured via helm chart for redundancy.

Suggested Solution (optional)

No response

Already existing or connected issues / PRs (optional)

No response

@yorugac
Copy link
Collaborator

yorugac commented Nov 4, 2023

Hi @josh-ferrell, thanks for opening this.
AFAIR, the issue of multiple replicas wasn't raised before. k6-operator does not support multiple replicas at the moment, regardless of what installation method you use. Which in practice means that some use cases would work with multiple replicas deployed and some might not.
So independently of Helm, could you please describe the use case for having more than 1 replica?

@josh-ferrell
Copy link
Contributor Author

josh-ferrell commented Nov 4, 2023

Having multiples running across zones for resiliency is a policy of ours. I assumed with the leader election that a second wouldn't be reconciling the CRs until they became the leader. TBH I'm not very familiar with k6 yet but if you can advise as to where multiple replicas would clash I can take a look at addressing them.

@yorugac
Copy link
Collaborator

yorugac commented Nov 6, 2023

@josh-ferrell I'm reviewing multiple replicas setup again and I believe you're right and we won't need to change anything. TBH, the last time I checked multiple replicas workflow was almost a year ago and leases just weren't present then (in our deps). But now it looks like yes, lease solves the issues: only one replica will reconcile the resources while the rest remain on standby.

FYI, I'll continue testing this and will come back to you (and PR) a bit later this week. And thanks again for bringing this up to attention! 😄

@yorugac
Copy link
Collaborator

yorugac commented Nov 13, 2023

Closed with #329

@yorugac yorugac closed this as completed Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants