Allow manager replicas to be configured via helm chart #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I tested this with manager.replicas set to two. Lease holder was correct so leader election seems to be working. Pods both became ready and stayed healthy. |
|
Successfully ran e2e tests |
yorugac
requested changes
Nov 13, 2023
There was a problem hiding this comment.
@josh-ferrell I'm happy to merge this change but there are a couple of small change requests: I suggest to change the name to replicas and if it's not an issue, please bump the Chart version to 3.0.0 - it's what triggers the release.
I'm going to add that last bit about versions to Contributing guide too.
josh-ferrell
force-pushed
the
feat/helm-replica-count
branch
from
6d8aae1
to
68c8325
Compare
josh-ferrell
force-pushed
the
feat/helm-replica-count
branch
from
68c8325
to
1eb6801
Compare
yorugac
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the number of manager replicas to be set via helm chart values. Enables #328