ci: add golang lint and fixed. #157 #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One more thing: can you please add a small instruction / command on how to run this linter locally? It could be a target in Makefile or part of internal docs (i.e. |
yorugac
reviewed
Oct 25, 2023
Makefile
Outdated
Comment on lines
102
to
104
| lint: | ||
| go install github.com/golangci/golangci-lint/cmd/[email protected] | ||
| golangci-lint --timeout 30m run ./... |
There was a problem hiding this comment.
Nice 🙌 Timeout is pretty large: our code base is rather small so shouldn't need that much in theory 🤔 Either way, this would work, thanks for adding Makefile change!
There was a problem hiding this comment.
@yorugac
I could reduce the timeout to 5min.
There was a problem hiding this comment.
👍 thanks. It should be fine with 5m, and if not, we can always tinker with it.
* use the latest version of golangci-lint in github actions * add the target of lint in Makefile * fix nolint errcheck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #157
Add golangci-lint on github actions ci and fixed some conventional issues of linting.