Call setup and teardown only once for PLZ
#358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #223
This PR implements the necessary logic only for PLZ test runs, thus leaving all other test runs as they have been executed so far.
Rationale: for a general case of OSS distributed test run, this logic is rather convoluted and implementing it in full would require to rather drastically intrude into standard logic of Kubernetes Job controller. From the design perspective, it would be preferable to implement full solution for
setupandteardownvia native distributed mode in k6 instead. Once that happens, PLZ test runs could also switch to using the logic of k6 distributed mode.