Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to adding the {{copy}} Killercoda action to all fenced code blocks #34

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

jdbaldry
Copy link
Member

@jdbaldry jdbaldry commented Jun 26, 2024

No need to use the copy directive, the default is copyable.
The exec directive overrides the {{copy}} action if its used.

Signed-off-by: Jack Baldry [email protected]

jdbaldry added 2 commits June 26, 2024 14:06
Always add the data-killercoda-copy attribute to fenced code blocks.

Signed-off-by: Jack Baldry <[email protected]>
@jdbaldry jdbaldry changed the title Add failing test for copy without directives transformation Default to adding the {{copy}} Killercoda action to all fenced code blocks Jun 26, 2024
@jdbaldry jdbaldry requested a review from Jayclifford345 June 26, 2024 13:11
Copy link
Collaborator

@Jayclifford345 Jayclifford345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working!

```alloy
 otelcol.receiver.otlp "default" {
   http {}
   grpc {}

   output {
     logs    = [otelcol.processor.batch.default.input]
   }
 }
```{{copy}}

LGTM!!

@jdbaldry jdbaldry merged commit d5b7935 into staging Jun 26, 2024
2 checks passed
@jdbaldry jdbaldry deleted the jdb/2024-06-default-to-copy branch June 27, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants