Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(policies): Per policy enforced labels #16182

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

salvacorts
Copy link
Contributor

What this PR does / why we need it:

Adds per-policy label enforcement. Enforced labels can only be declared via YAML as:

policy_enforced_labels:
   finance: ["taxregion", "agent"]
   staging: ["experimentid"]

The distributor enforces the labels resulted from compining policy_enforced_labels and the global enforced_labels.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Feb 11, 2025
Copy link
Contributor

github-actions bot commented Feb 11, 2025

@salvacorts salvacorts marked this pull request as ready for review February 11, 2025 14:04
@salvacorts salvacorts requested a review from a team as a code owner February 11, 2025 14:04
Copy link
Contributor

@DylanGuedes DylanGuedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work 🎉

do you think it might make sense to add a validation that warns if a policy_enforced_label is configured for some policy that doesn't have a mapping configured yet?

@salvacorts
Copy link
Contributor Author

salvacorts commented Feb 12, 2025

do you think it might make sense to add a validation that warns if a policy_enforced_label is configured for some policy that doesn't have a mapping configured yet?

I think that may actually be expected 🤔 a break glass procedure for a customer with a misbehaving policy may be to remove the mappings for that policy but leave the rest of the policy config as is.

Even if we wanna have that, I'd do it on a followup PR as we likely want it for the per policy blocked ingestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants