ci(wip): make the release workflows more generic and remove dependency from jsonnet #16194
+259
−645
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When trying to update our workflows me and @paul1r realized that the images and release workflows are generated using the jsonnet.
The current generated workflow is doing some duplication and playing with the quotes is hard to double check the generated file.
Trying to make one PR for the images workflow first that would make this more reusable.
We are defining a workflow that is responsible to build and push the images, this workflow will receive a set of inputs that will allow us to customize the workflow.
Advantages:
Special notes for your reviewer:
To avoid a way bigger PR decided to create one only for images and the release workflow will be in a different PR.
Updated the check.yml to validate the config since is a small workflow
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR