Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(wip): make the release workflows more generic and remove dependency from jsonnet #16194

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

fcjack
Copy link
Contributor

@fcjack fcjack commented Feb 11, 2025

What this PR does / why we need it:

When trying to update our workflows me and @paul1r realized that the images and release workflows are generated using the jsonnet.

The current generated workflow is doing some duplication and playing with the quotes is hard to double check the generated file.

Trying to make one PR for the images workflow first that would make this more reusable.
We are defining a workflow that is responsible to build and push the images, this workflow will receive a set of inputs that will allow us to customize the workflow.

Advantages:

  • No code repetition
  • To add a new image we only need to add a new job call with the right parameters
  • Workflow file consistency, we are following the syntax and standards of workflow definition

Special notes for your reviewer:

To avoid a way bigger PR decided to create one only for images and the release workflow will be in a different PR.
Updated the check.yml to validate the config since is a small workflow

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@fcjack fcjack self-assigned this Feb 11, 2025
@fcjack fcjack marked this pull request as ready for review February 12, 2025 08:57
@fcjack fcjack requested a review from a team as a code owner February 12, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant