Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose http.Client override through the main configuration #140

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jqueuniet
Copy link

An override to the remote http.Client has been added to the remote configuration with PR #101 , but using it seems to require reimplementing the Start function from the api package (unless I'm missing something). This PR adds an HTTPClient field to the main configuration struct to facilitate customization.

I guess there could be many different reasons to justify this, mine is to allow overriding the CA certificate store without rebuilding the system CA store, which can be difficult or even impossible in specific contexts.

@jqueuniet jqueuniet requested review from a team as code owners January 24, 2025 15:12
@CLAassistant
Copy link

CLAassistant commented Jan 24, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants