feat: expose http.Client override through the main configuration #140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An override to the remote
http.Client
has been added to the remote configuration with PR #101 , but using it seems to require reimplementing theStart
function from theapi
package (unless I'm missing something). This PR adds anHTTPClient
field to the main configuration struct to facilitate customization.I guess there could be many different reasons to justify this, mine is to allow overriding the CA certificate store without rebuilding the system CA store, which can be difficult or even impossible in specific contexts.