Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics-Generators: Reduce Wal TruncateFrequency to reduce memory usage #4317

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Metrics-Generators: Reduce Wal TruncateFrequency to reduce memory usage #4317

wants to merge 1 commit into from

Conversation

joe-elliott
Copy link
Member

What this PR does:
Reduces memory usage in the metrics-generators by reducing the amount of data kept in the prom wal. This has been reduced from 2h to 15m on recommendation from @mattdurham of the github.com/grafana/alloy team.

The impact is that Tempo can now only suffer a 15m network outage before there is data loss on remote write.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@joe-elliott
less memory means less pages
360949a 
Signed-off-by: Joe Elliott <[email protected]>
mdisibio
mdisibio approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@mdisibio mdisibio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable. Memory usage from the WAL is a significant portion, and the network tolerance seems acceptable. This pipeline already makes trade-offs vs durability.

@mattdurham
Copy link

15m is what we use for Alloy internally everywhere and rarely have issues with that time scale so it should be reasonable.

@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had any activity in the past 60 days.
The next time this stale check runs, the stale label will be removed if there is new activity. This pull request will be closed in 15 days if there is no new activity.
Please apply keepalive label to exempt this Pull Request.

@github-actions github-actions bot added the stale Used for stale issues / PRs label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdisibio mdisibio mdisibio approved these changes

@mapno mapno Awaiting requested review from mapno mapno is a code owner

@yvrhdn yvrhdn Awaiting requested review from yvrhdn yvrhdn is a code owner

@zalegrala zalegrala Awaiting requested review from zalegrala zalegrala is a code owner

@electron0zero electron0zero Awaiting requested review from electron0zero electron0zero is a code owner

@ie-pham ie-pham Awaiting requested review from ie-pham ie-pham is a code owner

@stoewer stoewer Awaiting requested review from stoewer stoewer is a code owner

@javiermolinar javiermolinar Awaiting requested review from javiermolinar javiermolinar is a code owner

Assignees
No one assigned
Labels
stale Used for stale issues / PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joe-elliott @mattdurham @mdisibio