Subgraph quickstart updates #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benface
reviewed
Jan 14, 2025
benface
reviewed
Jan 14, 2025
benface
reviewed
Jan 14, 2025
| @@ -49,7 +49,7 @@ The following command initializes your subgraph from an existing contract: | |||
| graph init | |||
| ``` | |||
|
|
|||
| If your contract was verified on Etherscan, then the ABI will automatically be created in the CLI. | |||
There was a problem hiding this comment.
Is there any reason to remove this? If we don't mention Etherscan, devs might not know where a contract gets "verified"
There was a problem hiding this comment.
I removed it because there's many kinds of blockscanners. Maybe simply saying a blockscanner instead of "Etherscan"?
idalithb
reviewed
Jan 14, 2025
Co-authored-by: Idalith <[email protected]>
benface
reviewed
Jan 14, 2025
benface
reviewed
Jan 14, 2025
benface
reviewed
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small changes to the phrasing of the subgraph quickstart.
Thanks!