Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor type conversions #1198

Open
saihaj opened this issue Mar 20, 2023 · 3 comments
Open

refactor type conversions #1198

saihaj opened this issue Mar 20, 2023 · 3 comments

Comments

@saihaj
Copy link
Member

saihaj commented Mar 20, 2023

Today we have a map that we maintain to convert between ABI, Assembly Script and that is what is what we simply use to map to GraphQL Types. This approach is liming because then we need to do hacks like this to fix issues with code-generation

@saihaj
Copy link
Member Author

saihaj commented Mar 20, 2023

#1025 will also help cause immutable makes it harder to deal with TS when writing and makes it harder to follow code.

@azf20
Copy link
Contributor

azf20 commented Mar 22, 2023

@saihaj what do you recommend instead of the current approach?

@saihaj
Copy link
Member Author

saihaj commented Mar 23, 2023

@saihaj what do you recommend instead of the current approach?

I think first step is moving away from the immutable and then I think we should create another MAP that maps a Value -> GraphQL type so there is a clear distinction on what a value will be converted to since today it is implicit inference that AssemblyScript -> Value == GraphQL Type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants