fix: make generated list children non-nullable #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saihaj
requested review from
azf20,
dotansimha,
enisdenjo,
incrypto32 and
schmidsi
🦋 Changeset detectedLatest commit: a6a309d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
azf20
approved these changes
Mar 21, 2023
enisdenjo
approved these changes
Mar 21, 2023
saihaj
deleted the
saihaj/1058-generated-schema-has-lists-with-nullable-members
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue where the ABI -> GraphQL type was doing a simple 1:1 mapping where
Array<Bytes> -> [Bytes]but forgraph-nodewe require that list items arenon-nullableso we need to make itArray<Bytes> -> [Bytes!]. I didn't want to introduce a big refactor so for now just making something that will work and accompanied test case. But we should revisit refactoring this logic.closes #1058