Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: tap core upgrade #133

Merged
merged 19 commits into from
Mar 13, 2024
Merged

refactor: tap core upgrade #133

merged 19 commits into from
Mar 13, 2024

Conversation

gusinacio
Copy link
Contributor

No description provided.

gusinacio added 18 commits March 6, 2024 16:38
Signed-off-by: Gustavo Inacio <[email protected]>
Signed-off-by: Gustavo Inacio <[email protected]>
Signed-off-by: Gustavo Inacio <[email protected]>
Signed-off-by: Gustavo Inacio <[email protected]>
@gusinacio gusinacio requested a review from aasseman March 13, 2024 00:51
Copy link
Contributor

github-actions bot commented Mar 13, 2024

Pull Request Test Coverage Report for Build 8270825568

Details

  • 271 of 459 (59.04%) changed or added relevant lines in 18 files are covered.
  • 29 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-1.3%) to 63.76%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/src/tap/checks/deny_list_check.rs 26 27 96.3%
tap-agent/src/tap/context.rs 16 17 94.12%
tap-agent/src/tap/context/error.rs 0 1 0.0%
tap-agent/src/tap/context/receipt.rs 23 27 85.19%
tap-agent/src/tap/context/rav.rs 29 34 85.29%
tap-agent/src/tap/escrow_adapter.rs 35 40 87.5%
tap-agent/src/tap/context/checks/signature.rs 20 27 74.07%
tap-agent/src/tap/context/escrow.rs 6 14 42.86%
tap-agent/src/tap/context/checks/allocation_id.rs 94 103 91.26%
common/src/indexer_service/http/indexer_service.rs 0 12 0.0%
Files with Coverage Reduction New Missed Lines %
common/src/indexer_errors.rs 1 0.0%
common/src/escrow_accounts.rs 4 79.74%
tap-agent/src/main.rs 11 0.0%
service/src/main.rs 13 0.0%
Totals Coverage Status
Change from base Build 8146052235: -1.3%
Covered Lines: 2859
Relevant Lines: 4484

💛 - Coveralls

@aasseman aasseman merged commit f7308d1 into main Mar 13, 2024
8 checks passed
@aasseman aasseman deleted the gusinacio/tap-core-upgrade branch March 13, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants