Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add support for auth-protected subgraph query URLs #226

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

Jannis
Copy link
Collaborator

@Jannis Jannis commented Jun 26, 2024

This allows to configure a bearer auth token for the network and escrow subgraphs, in case that is required for the endpoint used.

@Jannis Jannis requested review from LNSD, aasseman and hopeyen June 26, 2024 15:19
@gusinacio
Copy link
Contributor

Hey Jannis, thanks for contributing.

I'm assuming here that this PR is due to the shutdown of the hosted service.

The decentralized network exposes a way to embed the Api Key in the URL, would this still be necessary or is there any other case I'm missing?

@Jannis
Copy link
Collaborator Author

Jannis commented Jun 28, 2024

Hey Jannis, thanks for contributing.

I'm assuming here that this PR is due to the shutdown of the hosted service.

The decentralized network exposes a way to embed the Api Key in the URL, would this still be necessary or is there any other case I'm missing?

Indexers should be free to use whatever endpoints they want to query the network and escrow subgraphs. This change allows for instance to use endpoints that require an Authorization: Bearer ... header. An example would be another indexer with a free query auth token.

This allows to configure a bearer auth token for the network and
escrow subgraphs, in case that is required for the endpoint used.
@Jannis Jannis force-pushed the jannis/subgraph-auth-token branch from ec10732 to ff7639f Compare June 28, 2024 11:20
gusinacio and others added 2 commits July 3, 2024 16:29
It is commented-out because TOML does not support `null` optionals

Signed-off-by: Alexis Asseman <[email protected]>
@aasseman aasseman merged commit 4c7e16c into main Jul 3, 2024
9 of 10 checks passed
@aasseman aasseman deleted the jannis/subgraph-auth-token branch July 3, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants