Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid crashing if all receipts are invalid #261

Closed
wants to merge 6 commits into from

Conversation

carlosvdr
Copy link
Collaborator

@carlosvdr carlosvdr commented Jul 26, 2024

Solving issue #214
Added function along with this fix to tap-core

@carlosvdr carlosvdr requested a review from aasseman July 26, 2024 22:59
@carlosvdr carlosvdr self-assigned this Jul 26, 2024
@carlosvdr carlosvdr force-pushed the invalid-receipts-fix branch from 7cfe051 to 3e9f0e7 Compare July 26, 2024 23:06
@carlosvdr carlosvdr linked an issue Jul 26, 2024 that may be closed by this pull request
Copy link

gitguardian bot commented Jul 29, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11054344 Triggered Username Password 93bc3f5 tap-agent/minimal-config-example.toml View secret
11054344 Triggered Username Password 93bc3f5 tap-agent/maximal-config-example.toml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Contributor

Pull Request Test Coverage Report for Build 10168845147

Details

  • 69 of 88 (78.41%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 66.145%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tap-agent/src/agent/sender_allocation.rs 69 88 78.41%
Files with Coverage Reduction New Missed Lines %
common/src/tap/checks/deny_list_check.rs 1 93.64%
Totals Coverage Status
Change from base Build 10115454808: 0.1%
Covered Lines: 3890
Relevant Lines: 5881

💛 - Coveralls

@carlosvdr carlosvdr closed this Aug 7, 2024
@carlosvdr carlosvdr deleted the invalid-receipts-fix branch August 7, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store invalid receipts even if there are no valid ones in batch
1 participant