Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use router builder #513

Merged
merged 17 commits into from
Nov 26, 2024
Merged

refactor: use router builder #513

merged 17 commits into from
Nov 26, 2024

Conversation

gusinacio
Copy link
Contributor

No description provided.

@gusinacio gusinacio force-pushed the gustavo/tap-318-update-router-to-create-routes-near-the-route-file branch 4 times, most recently from ce28308 to b72fe1b Compare November 25, 2024 22:39
@gusinacio gusinacio changed the title Gustavo/tap 318 update router to create routes near the route file refactor: use router builder Nov 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12022337373

Details

  • 231 of 483 (47.83%) changed or added relevant lines in 17 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+4.0%) to 81.182%
Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/monitor/src/allocations.rs 0 1 0.0%
crates/service/src/routes/status.rs 0 1 0.0%
crates/monitor/src/client/subgraph_client.rs 7 9 77.78%
crates/service/src/database/mod.rs 0 2 0.0%
crates/service/src/routes/cost.rs 4 6 66.67%
crates/service/src/routes/health.rs 0 4 0.0%
crates/service/src/service/release.rs 0 12 0.0%
crates/tap-agent/src/agent.rs 0 14 0.0%
crates/service/src/metrics.rs 0 31 0.0%
crates/service/src/routes/dips.rs 0 32 0.0%
Files with Coverage Reduction New Missed Lines %
crates/monitor/src/client/subgraph_client.rs 1 77.03%
crates/service/src/tap/checks/deny_list_check.rs 1 98.15%
crates/service/src/service.rs 2 0.0%
Totals Coverage Status
Change from base Build 12015610543: 4.0%
Covered Lines: 6894
Relevant Lines: 8492
💛 - Coveralls

@gusinacio gusinacio force-pushed the gustavo/tap-318-update-router-to-create-routes-near-the-route-file branch 2 times, most recently from ed1c893 to 74eff2f Compare November 26, 2024 02:27
@gusinacio gusinacio requested a review from anirudh2 November 26, 2024 02:31
@gusinacio gusinacio marked this pull request as ready for review November 26, 2024 02:31
anirudh2
anirudh2 requested changes Nov 26, 2024
View reviewed changes
@gusinacio
refactor: add types to monitor
f2ff92d 
Signed-off-by: Gustavo Inacio <[email protected]>
@gusinacio
refactor: update subgraph client results
f98623e 
Signed-off-by: Gustavo Inacio <[email protected]>
@gusinacio
refactor: use router builder
d3756c8 
Signed-off-by: Gustavo Inacio <[email protected]>
@gusinacio
refactor: update router to use split config
ebacee8 
Signed-off-by: Gustavo Inacio <[email protected]>
@gusinacio
test: add integration test
a1eb906 
Signed-off-by: Gustavo Inacio <[email protected]>
@gusinacio
test: add insta
650f7b9 
Signed-off-by: Gustavo Inacio <[email protected]>
@gusinacio
refactor: use arc instead of leak
896ae4d 
Signed-off-by: Gustavo Inacio <[email protected]>
@gusinacio
test: use next()
57cb528 
Signed-off-by: Gustavo Inacio <[email protected]>
@gusinacio
refactor: remove useless client function
710c399 
Signed-off-by: Gustavo Inacio <[email protected]>
@gusinacio
chore: remove comment in dips
de65ec9 
Signed-off-by: Gustavo Inacio <[email protected]>
@gusinacio
docs: monitor types
fbdd8fa 
Signed-off-by: Gustavo Inacio <[email protected]>
@gusinacio
docs: shutdown handler
afb6d29 
Signed-off-by: Gustavo Inacio <[email protected]>
@gusinacio
test: use builder for signed receipt request
defb43b 
Signed-off-by: Gustavo Inacio <[email protected]>
@gusinacio gusinacio force-pushed the gustavo/tap-318-update-router-to-create-routes-near-the-route-file branch from 74eff2f to ca17221 Compare November 26, 2024 18:30
@gusinacio gusinacio force-pushed the gustavo/tap-318-update-router-to-create-routes-near-the-route-file branch from ca17221 to 60ac1c1 Compare November 26, 2024 18:36
anirudh2
anirudh2 requested changes Nov 26, 2024
View reviewed changes
@gusinacio gusinacio requested a review from anirudh2 November 26, 2024 22:44
anirudh2
anirudh2 approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@anirudh2 anirudh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @gusinacio!

@gusinacio gusinacio merged commit 430c5d4 into main Nov 26, 2024
10 checks passed
@gusinacio gusinacio deleted the gustavo/tap-318-update-router-to-create-routes-near-the-route-file branch November 26, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anirudh2 anirudh2 anirudh2 approved these changes

@pedrohba1 pedrohba1 Awaiting requested review from pedrohba1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gusinacio @anirudh2