Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change some names and add necessary fields to indexing agreements #597

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

pcarranzav
Copy link
Member

@pcarranzav pcarranzav commented Jan 31, 2025

  • Changed the database table for dips to indexing_agreements
  • Changed some field names for consistency (camelCase)
  • Added pricePerEntity to dips vouchers
  • Changed the types used for network names and addresses
  • Added a current allocation id to indexing agreements (will be used by the indexer agent)

@coveralls
Copy link

coveralls commented Feb 3, 2025

Pull Request Test Coverage Report for Build 13168522030

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 224 of 288 (77.78%) changed or added relevant lines in 5 files are covered.
  • 397 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.1%) to 78.703%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/dips/src/server.rs 0 16 0.0%
crates/dips/src/lib.rs 156 180 86.67%
crates/dips/src/proto/graphprotocol.gateway.dips.rs 0 24 0.0%
Files with Coverage Reduction New Missed Lines %
crates/dips/src/lib.rs 1 91.82%
crates/tap-agent/src/tap/context/escrow.rs 1 57.14%
crates/dips/src/server.rs 2 0.0%
crates/tap-agent/src/tap/context/rav.rs 14 84.76%
crates/tap-agent/src/test.rs 15 96.98%
crates/tap-agent/src/tap/context/receipt.rs 16 87.63%
crates/tap-agent/src/tap/context.rs 30 51.61%
crates/service/src/tap/receipt_store.rs 50 76.85%
crates/tap-agent/src/agent/sender_accounts_manager.rs 55 86.21%
crates/tap-agent/src/agent/sender_allocation.rs 62 89.89%
Totals Coverage Status
Change from base Build 13109844496: -0.1%
Covered Lines: 7328
Relevant Lines: 9311

💛 - Coveralls

@pcarranzav pcarranzav requested review from mangas and LNSD February 3, 2025 14:38
@pcarranzav pcarranzav marked this pull request as ready for review February 3, 2025 14:38
@pcarranzav pcarranzav marked this pull request as draft February 3, 2025 18:53
@pcarranzav
Copy link
Member Author

Back to Draft as I'm adding a few more changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants