Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check allocation id blocked before sending rav req #600

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

shiyasmohd
Copy link
Contributor

Fixes #598

@shiyasmohd shiyasmohd self-assigned this Feb 1, 2025
Copy link
Contributor

github-actions bot commented Feb 1, 2025

Pull Request Test Coverage Report for Build 13089259730

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.09%) to 78.903%

Files with Coverage Reduction New Missed Lines %
crates/tap-agent/src/agent/sender_account.rs 1 82.21%
crates/tap-agent/src/agent/sender_allocation.rs 2 89.23%
Totals Coverage Status
Change from base Build 13061413604: 0.09%
Covered Lines: 7050
Relevant Lines: 8935

💛 - Coveralls

@suchapalaver
Copy link
Contributor

@shiyasmohd looks like you need to rebase! Also, this all looks good to me, but I wanted to ask as I learn the codebase, would there be a test we could add that shows this fix working? Just generally really curious how people are testing whether it's locally or however. Thanks 🙏

@shiyasmohd
Copy link
Contributor Author

@suchapalaver I'll rebase and try to add test too. Please Ingore this Merge from main branch. I'll be fixing that too. Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error messages while aggregate a closing allocation
2 participants