Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: complete tap-agent docs #605

Merged
merged 12 commits into from
Feb 6, 2025
Merged

Conversation

gusinacio
Copy link
Member

Signed-off-by: Gustavo Inacio [email protected]

@coveralls
Copy link

coveralls commented Feb 5, 2025

Pull Request Test Coverage Report for Build 13184484119

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 78.823%

Files with Coverage Reduction New Missed Lines %
crates/tap-agent/src/metrics.rs 1 0.0%
crates/watcher/src/lib.rs 4 92.71%
Totals Coverage Status
Change from base Build 13182934072: -0.03%
Covered Lines: 7355
Relevant Lines: 9331

💛 - Coveralls

Copy link
Contributor

@suchapalaver suchapalaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incredible work @gusinacio - this makes the code so much more available to new contributors! 👏 ❤️

Just caught a few grammar type things and I think one place where I think we need to reword things to make it clear.

crates/tap-agent/src/adaptative_concurrency.rs Outdated Show resolved Hide resolved
crates/tap-agent/src/adaptative_concurrency.rs Outdated Show resolved Hide resolved
crates/tap-agent/src/adaptative_concurrency.rs Outdated Show resolved Hide resolved
crates/tap-agent/src/adaptative_concurrency.rs Outdated Show resolved Hide resolved
crates/tap-agent/src/adaptative_concurrency.rs Outdated Show resolved Hide resolved
crates/tap-agent/src/backoff.rs Outdated Show resolved Hide resolved
crates/tap-agent/src/lib.rs Outdated Show resolved Hide resolved
crates/tap-agent/src/lib.rs Outdated Show resolved Hide resolved
crates/tap-agent/src/tracker.rs Outdated Show resolved Hide resolved
crates/tap-agent/src/tracker/sender_fee_stats.rs Outdated Show resolved Hide resolved
@gusinacio gusinacio force-pushed the gustavo/add-missing-docs-lint branch from 4466411 to 035bd41 Compare February 6, 2025 15:47
Signed-off-by: Gustavo Inacio <[email protected]>
Signed-off-by: Gustavo Inacio <[email protected]>
Signed-off-by: Gustavo Inacio <[email protected]>
Signed-off-by: Gustavo Inacio <[email protected]>
Signed-off-by: Gustavo Inacio <[email protected]>
Signed-off-by: Gustavo Inacio <[email protected]>
Signed-off-by: Gustavo Inacio <[email protected]>
@gusinacio gusinacio force-pushed the gustavo/add-missing-docs-lint branch from 035bd41 to 40c6bd6 Compare February 6, 2025 15:48
Signed-off-by: Gustavo Inacio <[email protected]>
@gusinacio gusinacio force-pushed the gustavo/add-missing-docs-lint branch from efd901e to c71fc1d Compare February 6, 2025 15:54
Copy link
Contributor

@suchapalaver suchapalaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work!

@gusinacio gusinacio enabled auto-merge (squash) February 6, 2025 17:23
@gusinacio gusinacio merged commit abcd7fe into main Feb 6, 2025
10 checks passed
@gusinacio gusinacio deleted the gustavo/add-missing-docs-lint branch February 6, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants