Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add escape hatch to trusted senders #621

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Conversation

gusinacio
Copy link
Contributor

@gusinacio gusinacio commented Feb 11, 2025

Add feature for configuration that allows some senders to spend up to max_amount_willing_to_lose over the balance.

@gusinacio gusinacio changed the title feat: add escape hatch to trusted gateways feat: add escape hatch to trusted senders Feb 11, 2025
@gusinacio gusinacio force-pushed the gustavo/escape-hatch branch 3 times, most recently from 585b342 to 86444d2 Compare February 11, 2025 17:48
@gusinacio gusinacio marked this pull request as ready for review February 11, 2025 17:48
@gusinacio gusinacio force-pushed the gustavo/escape-hatch branch 3 times, most recently from 26beaf7 to 3921784 Compare February 11, 2025 18:26
@gusinacio gusinacio force-pushed the gustavo/escape-hatch branch from 3921784 to e0d5c73 Compare February 11, 2025 18:27
Copy link
Member

@Theodus Theodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gusinacio gusinacio enabled auto-merge (squash) February 11, 2025 20:55
@gusinacio gusinacio merged commit bdc40ef into main Feb 11, 2025
10 checks passed
@gusinacio gusinacio deleted the gustavo/escape-hatch branch February 11, 2025 21:01
@github-actions github-actions bot mentioned this pull request Feb 11, 2025
@coveralls
Copy link

coveralls commented Feb 13, 2025

Pull Request Test Coverage Report for Build 13272304166

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 17 of 18 (94.44%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 79.685%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/tap-agent/src/agent/sender_account.rs 9 10 90.0%
Totals Coverage Status
Change from base Build 13272299523: 0.1%
Covered Lines: 8033
Relevant Lines: 10081

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants