Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: parse v2 receipts #631

Merged
merged 1 commit into from
Feb 13, 2025
Merged

refactor: parse v2 receipts #631

merged 1 commit into from
Feb 13, 2025

Conversation

gusinacio
Copy link
Member

@gusinacio gusinacio commented Feb 13, 2025

  • Try to decode a base64 before trying serde_json.
  • If success, proceed to decode using Protobuf for v2
  • otherwise use normal v1 serde_json deserialization process

@gusinacio gusinacio force-pushed the gustavo/parse-v2-receipts branch from e5c231d to 9934a78 Compare February 13, 2025 19:56
Signed-off-by: Gustavo Inacio <[email protected]>
@gusinacio gusinacio force-pushed the gustavo/parse-v2-receipts branch from 9934a78 to a08cd32 Compare February 13, 2025 20:53
@gusinacio gusinacio marked this pull request as ready for review February 13, 2025 20:53
Copy link
Contributor

@suchapalaver suchapalaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@gusinacio gusinacio merged commit 77dc51c into main Feb 13, 2025
10 checks passed
@gusinacio gusinacio deleted the gustavo/parse-v2-receipts branch February 13, 2025 21:08
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13316871610

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 44 of 44 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on gustavo/parse-v2-receipts at 75.797%

Totals Coverage Status
Change from base Build 13316828029: 75.8%
Covered Lines: 8346
Relevant Lines: 11011

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants