-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create indexer service framework #80
Conversation
96747e3
to
0d8bbb7
Compare
Pull Request Test Coverage Report for Build 6660418515
💛 - Coveralls |
f1866b5
to
8eee89c
Compare
738dfee
to
258964c
Compare
Pull Request Test Coverage Report for Build 7066306592
💛 - Coveralls |
c6f220b
to
6f7316a
Compare
21fa80d
to
daa7acd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very 🧠 !
d0937fb
to
b5e6938
Compare
@hopeyen Addressed your comments so far! |
cb91f6e
to
882d7f0
Compare
This uses tower-governor instead of tower::limit::RateLimitLayer, as it is a little more powerful.
882d7f0
to
760df33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clean! LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clean! LGTM!
This introduces a framework for writing any type of HTTP-based indexer service using a skeleton like the one below. A working implementation for one of the upcoming data services already exists, my next goal is to port the existing subgraph indexer-service in this repository to this framework as well. But that will happen in a separate PR.