Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert executor to class #4315

Closed
wants to merge 4 commits into from
Closed

Conversation

yaacovCR
Copy link
Contributor

  1. introduces Executor class so we can more easily add generic type parameters to the necessary functions
  2. extracts generic Payload Publisher from the IncrementalPublisher class and makes Executor generic
  3. adds legacy entrypoints

TODO: tests

Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 4612e99
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/6765274b027b280008cbc111
😎 Deploy Preview https://deploy-preview-4315--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR yaacovCR changed the title WIP: legacy incremental format convert executor to class Dec 20, 2024
@yaacovCR
Copy link
Contributor Author

Closing for now, use case was for #4316 => which may have to go in a different direction.

@yaacovCR yaacovCR closed this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant