style: enable prettier for mdx files #1907
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dimaMachina
reviewed
Dec 23, 2024
i think all this was migrated but we didn't remove it.
|
Hold fire on this. |
|
Okay I dug up the bug with proseWrap in MDX / bug report. Yes, we must disable proseWrap in MDX if we enable prettier; generally I don't trust it with MDX files. I've taken to just un-ignoring each new MDX file I add - perhaps we should ignore certain problematic files but enable? |
|
@saihaj is it possible to generate the static website before and after this change and assert that there are no differences in the generated output? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why we disabled prettier for
.mdxfiles. I was working on some other PR and saw it wasn't working so decided to enable for everything.