Keep last results until test result finishes #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes fetch the previous run's results when a new run starts. This allows the user to keep looking at the previous results while watch mode starts a new test run. This can save a lot of time because the user can start looking at the next failure that needs to be fixed while the tests are run on the latest change. Without these changes, the previous run's results were discarded as soon as the new test run started. That meant that the developer had to sit there waiting for the results of the new run just to see the error condition on the next test that was on screen before she pressed save. I added typing to the 'results' map in the results.ts file to make the results easier to work with.
I wanted to provide an additional visual cue to the user that the results they were looking at were out of date, but still alow them to view the results while the other results were being generated. Using the information from this SO question: https://stackoverflow.com/questions/48502647/conditional-rendering-in-styled-components I added a dim property to the Content panel that is triggered on isUpdating.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue Raathigesh#201
When a user starts a test run, the old results are still shown, but they are dimmed (50% opacity) while the test is running. When the new test results are available, the new test results replace the old test results.
The difference between this and the old behaviour was that in the old behaviour, the old test results were discarded as soon as the test run started. This causes the user to have to sit there waiting for the test to complete before seeing the information that used to be there before the test started if there were additional test failures that were fixed with the new test run. It led to a waste of developer time.