feat(protoc-gen-openapiv2/template): updateSwaggerObjectFromFieldBeha…

[Ccheers]

…vior add default required rule

References to other Issues or PRs

Have you read the Contributing Guidelines?

Brief description of what is fixed or changed

Other comments

[johanbrandhorst]

Hi, thanks for your PR. Is there an issue this relates to? What is this fixing? Looks to be something related to field behavior?

[Ccheers]

Hi, thanks for your PR. Is there an issue this relates to? What is this fixing? Looks to be something related to field behavior?

In proto3, all fields are Required by default, and the generated pb files are also Required, so the field behavior should be Required by default.

[johanbrandhorst]

Hm, I suppose that might make sense. Looks like there are quite a few test errors, could you try and fix those please? Also you'll need to regenerate the files, see CONTRIBUTING.md.

[Ccheers]

Hm, I suppose that might make sense. Looks like there are quite a few test errors, could you try and fix those please? Also you'll need to regenerate the files, see CONTRIBUTING.md.

ok

[johanbrandhorst]

I'm sort of worried that this is going to be a breaking change for users. It may be a semantically correct translation from the proto3 definitions, but this is going to change a LOT of people's swagger definitions. What do you think about adding an option for this? use_proto3_field_semantics perhaps?

[Ccheers]

I'm sort of worried that this is going to be a breaking change for users. It may be a semantically correct translation from the proto3 definitions, but this is going to change a LOT of people's swagger definitions. What do you think about adding an option for this? use_proto3_field_semantics perhaps?

Good Idea 👍