Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing parsing of sizes in GPU #1554

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Fixing parsing of sizes in GPU #1554

merged 1 commit into from
Jan 24, 2024

Conversation

nicolasnoble
Copy link
Member

Sometimes size values could get negative, resulting in excessive memory usage.

Sometimes size values could get negative, resulting in excessive memory usage.
@ghost
Copy link

ghost commented Jan 24, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (41c5d3a) 9.26% compared to head (e9cc0d7) 9.26%.

Files Patch % Lines
src/core/gpu.cc 0.00% 11 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1554   +/-   ##
=======================================
  Coverage    9.26%    9.26%           
=======================================
  Files         437      437           
  Lines      128784   128783    -1     
=======================================
  Hits        11933    11933           
+ Misses     116851   116850    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicolasnoble nicolasnoble merged commit de48a69 into main Jan 24, 2024
16 of 17 checks passed
@nicolasnoble nicolasnoble deleted the gpu-parser-fixes branch January 24, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant