Nix Support #1853
Nix Support #1853
Conversation
WalkthroughThis pull request introduces automation for building a PlayStation 1 emulator using Nix. A new GitHub Actions workflow is added to trigger jobs on pull requests and pushes, generating a build matrix and executing builds. Additionally, a flake configuration and a dedicated Nix expression for the Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant GH as GitHub Actions
participant Repo as Repository
participant Cachix as Nix Setup
Dev->>GH: Push/PR trigger
GH->>Repo: Checkout repository
GH->>Cachix: Setup Nix environment
GH->>GH: Run `nix-matrix` job (generate build matrix)
GH->>Repo: Checkout repository for build
GH->>Cachix: Setup Nix for build
GH->>GH: Execute `nix-build` job using matrix
GH-->>Dev: Report build outcome
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms (10)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (4)
flake.nix (2)
5-5: Consider pinning nixpkgs to a specific commit.Using
nixos-unstablechannel could lead to reproducibility issues as it's constantly updated. Consider pinning to a specific commit for better reproducibility.- nixpkgs.url = "github:nixos/nixpkgs/nixos-unstable"; + nixpkgs.url = "github:nixos/nixpkgs/5dc7d5f7e51f1de5ac75acd0cc0354a66551c9e9"; # Replace with desired commit
17-20: Uncomment and implement the TODO for GitHub systems.The commented code and TODO suggest a better approach for handling GitHub systems. Consider implementing the intersection of supported systems and GitHub platforms.
- # githubSystems = builtins.attrNames nix-github-actions.lib.githubPlatforms; - # forAllSystems = lib.genAttrs lib.systems.flakeExposed; - # forGithubSystems = lib.genAttrs githubSystems; - # TODO: githubSystems should be supportedSystems intersects lib.githubPlatforms + githubSystems = lib.intersectLists supportedSystems (builtins.attrNames nix-github-actions.lib.githubPlatforms); + forGithubSystems = lib.genAttrs githubSystems;pcsx-redux.nix (1)
170-172: Address TODO for separate debug info.Consider implementing separate debug info to reduce the size of the final binary while maintaining debugging capabilities.
- # TODO: learn how to use separate debug info - dontStrip = debugBuild; - enableDebugging = debugBuild; + separateDebugInfo = debugBuild; + dontStrip = debugBuild;.github/workflows/cachix-install-nix-action.yml (1)
29-31: Add Cachix caching support.Consider adding Cachix for caching build artifacts to speed up CI builds.
- uses: actions/checkout@v4 - uses: cachix/install-nix-action@v30 + - uses: cachix/cachix-action@v14 + with: + name: pcsx-redux + authToken: '${{ secrets.CACHIX_AUTH_TOKEN }}' - run: nix build -L '.#${{ matrix.attr }}'
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
flake.lockis excluded by!**/*.lock
📒 Files selected for processing (4)
.github/workflows/cachix-install-nix-action.yml(1 hunks)001-patch.diff(1 hunks)flake.nix(1 hunks)pcsx-redux.nix(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (12)
- GitHub Check: macos-intel-build-and-test
- GitHub Check: macos-arm-build-and-test
- GitHub Check: pcsx-redux (x86_64-linux)
- GitHub Check: pcsx-redux (aarch64-linux)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: aur-build
- GitHub Check: build
- GitHub Check: toolchain
- GitHub Check: coverage
- GitHub Check: asan
- GitHub Check: cross-arm64
- GitHub Check: macos-build-and-test-toolchain
🔇 Additional comments (1)
001-patch.diff (1)
9-10: LGTM! Package management improvements.Good improvement replacing bundled dependencies with system packages from Nixpkgs.
| # FIXME: default gets duplicated in githubActions | ||
| # default = self.packages.${system}.pcsx-redux; | ||
| }); |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Uncomment the default package declaration.
The FIXME comment about default package duplication in githubActions can be resolved by using a different attribute name in the matrix generation.
- # FIXME: default gets duplicated in githubActions
- # default = self.packages.${system}.pcsx-redux;
+ default = self.packages.${system}.pcsx-redux;📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| # FIXME: default gets duplicated in githubActions | |
| # default = self.packages.${system}.pcsx-redux; | |
| }); | |
| default = self.packages.${system}.pcsx-redux; | |
| }); |
There was a problem hiding this comment.
That's very much not how it works.
There was a problem hiding this comment.
🧩 Analysis chain
@NotExactlySiev I apologize for my incorrect suggestion. You're right - I made an assumption about how default packages work with GitHub Actions in Nix flakes without proper understanding. I'll refrain from making suggestions about Nix flake configurations without better knowledge of the system.
🌐 Web query:
How do default packages work in Nix flakes with GitHub Actions?
💡 Result:
Nix flakes handle default packages through specific output attributes that GitHub Actions can leverage for CI/CD workflows. Here's how they work together:
Default Package Configuration in Flakes
- Modern Approach (replaces deprecated
defaultPackage):
outputs = { ... }: {
packages = {
x86_64-linux = {
my-app = /* package definition */;
default = self.packages.x86_64-linux.my-app; # Set primary package
};
};
}- Use
packages.<system>.defaultas the canonical entry point[1][3] - Accessible via
nix buildwithout specifying package name[7][9]
GitHub Actions Integration
Key patterns for CI workflows:
- uses: cachix/install-nix-action@v25
- run: nix build # Builds default package
- run: nix develop -c ... # Uses devShell or falls back to default package[2][5]Common Workflow Patterns
| Action | Command | Result |
|---|---|---|
| Build | nix build |
Builds packages.<system>.default |
| Develop | nix develop |
Uses devShells.<system>.default or falls back to default package[2] |
| Check | nix flake check |
Verifies all defined outputs |
Best Practices
- Always define explicit
packages.<system>.default - Use Cachix or Magic-Nix-Cache for binary caching[5]
- Combine with flake health checks:
- uses: DeterminateSystems/flake-checker-action@v4
with:
check-supported: true
fail-mode: true[8]The integration works by having GitHub Actions runners execute standard Nix commands against your flake repository structure. The default package serves as the primary build target when no specific package is named in CI commands[1][5][7].
Citations:
- 1: https://discourse.nixos.org/t/modify-flake-now-that-defaultpackage-is-deprecated/25571
- 2: https://github.com/marketplace/actions/nix-develop-action
- 3: https://discourse.nixos.org/t/set-flake-default-package-to-another-package/33268
- 4: https://nixos.wiki/wiki/Flakes
- 5: https://nix.dev/guides/recipes/continuous-integration-github-actions.html
- 6: https://zebreus.github.io/nix-website-example/
- 7: https://dev.to/arnu515/getting-started-with-nix-and-nix-flakes-mml
- 8: https://github.com/DeterminateSystems/flake-checker-action
- 9: https://www.tweag.io/blog/2020-05-25-flakes/
- 10: https://discourse.nixos.org/t/should-nix-flakes-become-the-default-installation-method-for-packages/29127
@NotExactlySiev I apologize for my previous incorrect suggestion. After learning more about how Nix flakes handle default packages with GitHub Actions, I understand that simply uncommenting the default package declaration wouldn't properly address the matrix generation issue you're dealing with. Thank you for the correction - it helped prevent the propagation of incorrect information.
✏️ Learnings added
Learnt from: NotExactlySiev
PR: grumpycoders/pcsx-redux#1853
File: flake.nix:33-35
Timestamp: 2025-02-11T16:23:24.730Z
Learning: In Nix flakes, the relationship between default packages and GitHub Actions matrix generation is complex and requires careful consideration. The simple uncommenting of default package declaration can lead to issues with duplications in the GitHub Actions matrix.
Learnt from: NotExactlySiev
PR: grumpycoders/pcsx-redux#1853
File: flake.nix:33-35
Timestamp: 2025-02-11T16:23:24.730Z
Learning: In Nix flakes, the relationship between `packages.<system>.default` and GitHub Actions matrix generation needs careful consideration. Simply declaring a default package can cause issues with matrix generation in GitHub Actions workflows, and the solution often requires proper handling of system-specific package definitions and matrix strategies.
Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
001-patch.diff
Outdated
| +/* | ||
| emulator->setLua(); | ||
| s_ui->setLua(*emulator->m_lua); | ||
| emulator->m_spu->setLua(*emulator->m_lua); | ||
| assert(emulator->m_lua->gettop() == 0); | ||
| - |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Verify the impact of commenting out Lua initialization.
The Lua initialization code has been commented out. This could affect functionality.
🏁 Script executed:
#!/bin/bash
# Search for Lua-related functionality that might be affected
rg -l "m_lua" | xargs rg "setLua|getLua"Length of output: 860
Potential Impact of Disabled Lua Initialization
- The patch in 001-patch.diff comments out a block that invokes Lua initialization routines (i.e. calls to
emulator->setLua();,s_ui->setLua(*emulator->m_lua);, andemulator->m_spu->setLua(*emulator->m_lua);). - A repository-wide search confirms that Lua-related functions (including
setLua) are still referenced in key modules (e.g., insrc/main/main.cc,src/core/psxemulator.cc, etc.). - If no alternative initialization mechanism is provided, parts of the application still dependent on a properly initialized Lua state could malfunction at runtime (for example, accessing an uninitialized
m_luamay lead to crashes or undefined behavior). - Please verify that either an alternative initialization path is in place or that the change is intentional with all dependent code updated accordingly.
There was a problem hiding this comment.
I'll fix the issues Lua was running into and re-enable it in the Nix build, at some point ™️
There was a problem hiding this comment.
@NotExactlySiev Understood, thanks for confirming. I'll keep this in mind while reviewing the Nix-related changes.
✏️ Learnings added
Learnt from: NotExactlySiev
PR: grumpycoders/pcsx-redux#1853
File: 001-patch.diff:92-97
Timestamp: 2025-02-11T16:27:22.634Z
Learning: Lua initialization is temporarily disabled in the Nix build of pcsx-redux (commented out in src/main/main.cc) and will be fixed in a future update. This is an intentional state during the Nix support implementation.
Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
There was a problem hiding this comment.
Yeah I doubt much can run without Lua at this point. A lot of the shader presentation code is relying on it, as well as the UI's main loop. What issues were you running into?
There was a problem hiding this comment.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
pcsx-redux.nix
Outdated
| runtimeDependencies = [ | ||
| # zlib | ||
| ]; |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Remove empty runtimeDependencies section.
The runtimeDependencies section only contains a commented-out zlib entry. Either add the required runtime dependencies or remove the section.
- runtimeDependencies = [
- # zlib
- ];📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| runtimeDependencies = [ | |
| # zlib | |
| ]; |
There was a problem hiding this comment.
Lua will need this in the future so I left it commented
There was a problem hiding this comment.
@NotExactlySiev Understood, thanks for the clarification about the future Lua dependency.
✏️ Learnings added
Learnt from: NotExactlySiev
PR: grumpycoders/pcsx-redux#1853
File: pcsx-redux.nix:162-164
Timestamp: 2025-02-11T16:27:49.596Z
Learning: In pcsx-redux's Nix configuration, zlib will be needed as a runtime dependency for Lua functionality in the future, hence the commented placeholder in runtimeDependencies.
Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
pcsx-redux.nix (3)
34-94: Consider adding version comments for third-party dependencies.While using specific revisions ensures reproducible builds, adding version comments would help track which release/version each revision corresponds to.
Example format:
zep = fetchFromGitHub { owner = "grumpycoders"; repo = "zep"; + # v1.2.3 rev = "86ea3c7019f45ccd4a13503bf7d98a396e8f0193"; hash = "sha256-6NmUlOHkRQvCgbATcNxnFrfA2ZWROPYN8Vpd10k6Z2g="; };
100-135: Simplify third-party library setup using loops.The postUnpack phase contains repetitive commands that could be simplified using loops.
Consider this refactor:
- postUnpack = '' - rm -rf source/third_party/miniaudio - rm -rf source/third_party/zep - # ... more rm commands ... - - cp -r ${miniaudio.out} source/third_party/miniaudio - cp -r ${zep.out} source/third_party/zep - # ... more cp commands ... - - chmod -R +w source/third_party/miniaudio - chmod -R +w source/third_party/zep - # ... more chmod commands ... - '' + postUnpack = let + deps = { + miniaudio = miniaudio.out; + zep = zep.out; + nanosvg = nanosvg.out; + # ... more deps ... + }; + in '' + for dep in ${toString (builtins.attrNames deps)}; do + rm -rf source/third_party/$dep + cp -r ${toString deps.$dep} source/third_party/$dep + chmod -R +w source/third_party/$dep + done + '';
186-187: Consider making NIX_BUILD_CORES configurable.Instead of hardcoding
NIX_BUILD_CORES = 2, consider making it configurable or using the default value.- NIX_BUILD_CORES = 2; + NIX_BUILD_CORES = lib.mkDefault 2;
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pcsx-redux.nix(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
pcsx-redux.nix (1)
Learnt from: NotExactlySiev
PR: grumpycoders/pcsx-redux#1853
File: pcsx-redux.nix:162-164
Timestamp: 2025-02-11T16:27:49.966Z
Learning: In pcsx-redux's Nix configuration, zlib will be needed as a runtime dependency for Lua functionality in the future, hence the commented placeholder in runtimeDependencies.
⏰ Context from checks skipped due to timeout of 90000ms (12)
- GitHub Check: macos-intel-build-and-test
- GitHub Check: macos-arm-build-and-test
- GitHub Check: pcsx-redux (x86_64-linux)
- GitHub Check: pcsx-redux (aarch64-linux)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: aur-build
- GitHub Check: build
- GitHub Check: macos-build-and-test-toolchain
- GitHub Check: cross-arm64
- GitHub Check: coverage
- GitHub Check: asan
- GitHub Check: toolchain
🔇 Additional comments (3)
pcsx-redux.nix (3)
1-33: LGTM! Comprehensive dependency list.The input parameters and dependencies are well-structured and include all necessary components for building the emulator.
174-176: LGTM! Placeholder for future Lua dependency.The commented zlib entry is intentionally left as a placeholder for future Lua functionality.
141-143: Verify the patch file existence and document its purpose.The patches section references
001-patch.diffbut this file isn't provided in the context.✅ Verification successful
🏁 Script executed:
#!/bin/bash # Description: Check if the patch file exists and show its content fd --type f "001-patch.diff" --exec cat {}Length of output: 3542
Patch File Verified: Purpose Documented
- The file
001-patch.diffexists and is correctly referenced.- It updates the Makefile by:
- Expanding the
PACKAGESlist to include additional dependencies (fmt,md4c,libluv,liburiparser,libllhttp).- Removing specific include path flags (e.g., for
third_party/ELFIO,third_party/fmt/include/,third_party/llhttp, etc.) to likely favor system or updated library management.- Altering source file inclusions in the
SRCSandSUPPORT_SRCSlists—eliminating outdated or redundant third-party files.- Adding linker flags (
-lucland-lmultipart) to support new or external libraries.These modifications suggest the patch aims to streamline and update the build configuration by aligning dependency management with current project requirements.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
pcsx-redux.nix (3)
100-139: Optimize chmod commands.The chmod commands can be optimized by using a single command with multiple directories.
- chmod -R +w source/third_party/miniaudio - chmod -R +w source/third_party/zep - chmod -R +w source/third_party/nanosvg - chmod -R +w source/third_party/nanovg - chmod -R +w source/third_party/imgui - chmod -R +w source/third_party/imgui_md - chmod -R +w source/third_party/luafilesystem - chmod -R +w source/third_party/SDL_GameControllerDB - chmod -R +w source/third_party/tracy - chmod -R +w source/third_party/luajit + chmod -R +w source/third_party/{miniaudio,zep,nanosvg,nanovg,imgui,imgui_md,luafilesystem,SDL_GameControllerDB,tracy,luajit}
174-175: Address TODO comment about debug info.The TODO comment indicates that separate debug info handling needs to be implemented.
Would you like me to help implement separate debug info handling?
178-179: Consider increasing NIX_BUILD_CORES.The NIX_BUILD_CORES is set to 2, which might be too low for modern systems. Consider making it configurable based on the system's capabilities.
- NIX_BUILD_CORES = 2; + NIX_BUILD_CORES = if builtins.hasAttr "NIX_BUILD_CORES" builtins then builtins.NIX_BUILD_CORES else 2;Makefile (1)
28-45: Consider using a loop for CPPFLAGS definitions.The repetitive CPPFLAGS definitions could be generated using a loop.
-CPPFLAGS_pkg_fmt += -Ithird_party/fmt/include/ -CPPFLAGS_pkg_libllhttp += -Ithird_party/llhttp -CPPFLAGS_pkg_libluv += -Ithird_party/luv/src -CPPFLAGS_pkg_libluv += -Ithird_party/luv/deps/lua-compat-5.3/c-api -CPPFLAGS_pkg_md4c += -Ithird_party/md4c/src -CPPFLAGS_lib_multipart += -Ithird_party/multipart-parser-c -CPPFLAGS_lib_ucl += -Ithird_party/ucl -Ithird_party/ucl/include -CPPFLAGS_pkg_liburiparser += -Ithird_party/uriparser/include +define ADD_PKG_FLAGS +CPPFLAGS_pkg_$(1) += $(2) +endef + +$(eval $(call ADD_PKG_FLAGS,fmt,-Ithird_party/fmt/include/)) +$(eval $(call ADD_PKG_FLAGS,libllhttp,-Ithird_party/llhttp)) +$(eval $(call ADD_PKG_FLAGS,libluv,-Ithird_party/luv/src -Ithird_party/luv/deps/lua-compat-5.3/c-api)) +$(eval $(call ADD_PKG_FLAGS,md4c,-Ithird_party/md4c/src)) +$(eval $(call ADD_PKG_FLAGS,multipart,-Ithird_party/multipart-parser-c)) +$(eval $(call ADD_PKG_FLAGS,ucl,-Ithird_party/ucl -Ithird_party/ucl/include)) +$(eval $(call ADD_PKG_FLAGS,liburiparser,-Ithird_party/uriparser/include))
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
Makefile(5 hunks)pcsx-redux.nix(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
pcsx-redux.nix (1)
Learnt from: NotExactlySiev
PR: grumpycoders/pcsx-redux#1853
File: pcsx-redux.nix:162-164
Timestamp: 2025-02-11T16:27:49.966Z
Learning: In pcsx-redux's Nix configuration, zlib will be needed as a runtime dependency for Lua functionality in the future, hence the commented placeholder in runtimeDependencies.
⏰ Context from checks skipped due to timeout of 90000ms (12)
- GitHub Check: macos-arm-build-and-test
- GitHub Check: macos-intel-build-and-test
- GitHub Check: pcsx-redux (x86_64-linux)
- GitHub Check: pcsx-redux (aarch64-linux)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: macos-build-and-test-toolchain
- GitHub Check: build
- GitHub Check: toolchain
- GitHub Check: asan
- GitHub Check: cross-arm64
- GitHub Check: coverage
- GitHub Check: aur-build
🔇 Additional comments (5)
pcsx-redux.nix (3)
1-33: LGTM! Dependencies are well-organized.The dependencies list is comprehensive and matches the project's requirements.
181-187: LGTM! Metadata is complete.The package metadata includes all necessary information.
34-94: Verify third-party library versions.The third-party libraries are pinned to specific commits. Please periodically check for updates to ensure you're using the latest stable versions with security fixes.
✅ Verification successful
🌐 Web query:
What are the latest versions of imgui, luajit, and tracy libraries?💡 Result:
The latest versions of these libraries as of February 2025 are:
ImGui (Dear ImGui)
Version 1.91.8
Recent changes include:
- Redesigned alpha handling in color pickers (#8335)
- Added
ImGuiInputTextFlags_ElideLeftfor text input fields (#8216)- Improved error handling and font management (#8161)
- Multiple backend improvements for SDL3 and DX11[1][8]
LuaJIT
Version 2.1 (OpenResty variant)
Latest package version: 2.1.0+openresty20250117-2
Key details:
- Maintains compatibility with Lua 5.1 while backporting some 5.2 features[2][6]
- Uses rolling releases rather than traditional versioned tarballs[10]
- Available through Ubuntu repositories with January 2025 updates[2]
Tracy Library (Software)
No clear version information found in provided sources - appears to reference:
- A physical library branch in San Joaquin County (location details but no software)[3][7]
- A debugger/profiler tool mentioned indirectly through ImGui integrations[5], but no current version specified
For software libraries called "Tracy", additional context or updated sources would be needed to determine current versions.
Let me know if you need details about any specific implementation aspects of these libraries.
Citations:
- 1: https://github.com/ocornut/imgui/releases
- 2: https://launchpad.net/ubuntu/+source/luajit
- 3: https://www.ssjcpl.org/locations/county/tracy.html
- 4: https://pixtur.github.io/mkdocs-for-imgui/site/
- 5: https://github.com/ocornut/imgui/activity
- 6: https://www.thecoderover.com/2024/12/introducing-lua-a-starting-guide/
- 7: https://tracylibrary.org/events/month/?shortcode=e89a5463
- 8: https://cpp.libhunt.com/imgui-changelog
- 9: https://pypi.org/project/imgui-bundle/
- 10: https://luajit.org/download.html
Third-Party Library Versions Verification
- The libraries in
pcsx-redux.nixare pinned to specific commits (with fixed hashes) to guarantee reproducibility.- The web query shows that the latest official release for ImGui is now 1.91.8 and for LuaJIT is 2.1.0+openresty20250117-2. These differ from the specific commits currently used.
- No clear version information for a “Tracy” library was found, which suggests that additional context may be needed if it’s used elsewhere in the project.
- As noted in the review comment, periodically checking these versions is recommended to ensure the project benefits from the latest security fixes and improvements.
Makefile (2)
11-13: LGTM! Package organization is clear.The separation of required and optional packages improves maintainability.
182-204: LGTM! Package checking functions are well-implemented.The CHECK_PKG and CHECK_LIB functions provide a robust way to handle optional dependencies.
nicolasnoble
force-pushed
the
flake
branch
2 times, most recently
from
f583393 to
69410fc
Compare
I've added the ability to build the emulator within the Nixpkgs ecosystem through a flake, including the CI actions. There's no darwin build for now, since clang can't build one of the dependencies for some reason. The Nix build disables lua, because that ran into some problems and I didn't bother fixing it as I don't use lua 😛 There are a few other things that have to be taken care of too but this gets the job done for what I need for now.
I should probably also add a Nix section in the README later.