glib: Deprecate SendWeakRef::new() because implementation is unsound

gtk-rs · Jan 7, 2025 · f58de6c · f58de6c
1 parent 96e4705
commit f58de6c
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/glib/src/object.rs b/glib/src/object.rs
@@ -3575,6 +3575,7 @@ pub struct SendWeakRef<T: ObjectType>(WeakRef<T>, Option<usize>);
 
 impl<T: ObjectType> SendWeakRef<T> {
     #[inline]
+    #[deprecated = "Use from() instead. See https://github.com/gtk-rs/gtk-rs-core/issues/1617"]
     pub fn new() -> SendWeakRef<T> {
         SendWeakRef(WeakRef::new(), None)
     }
@@ -3615,6 +3616,7 @@ impl<T: ObjectType> Clone for SendWeakRef<T> {
 impl<T: ObjectType> Default for SendWeakRef<T> {
     #[inline]
     fn default() -> Self {
+        #[allow(deprecated)]
         Self::new()
     }
 }