Add doc for ConstructCell, improve doc Boxed, Enum #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They can't, neither can flags :) |
sdroege
reviewed
Jan 31, 2023
glib-macros/src/lib.rs
Outdated
| @@ -445,7 +446,7 @@ pub fn closure_local(item: TokenStream) -> TokenStream { | |||
| /// use glib::subclass::prelude::*; | |||
| /// | |||
| /// #[derive(Debug, Copy, Clone, PartialEq, Eq, glib::Enum)] | |||
| /// #[enum_type(name = "MyEnum")] | |||
| /// #[enum_type(name = "MyEnum", nullable)] | |||
There was a problem hiding this comment.
I'd expect this to fail. It should :)
There was a problem hiding this comment.
Except it doesn't fail. The doc check failed for other network related reasons.
There was a problem hiding this comment.
Yeah it doesn't check if there are random other, unknown attributes apparently.
There was a problem hiding this comment.
So just remove the wrong attribute here for now :)
sdroege
reviewed
Jan 31, 2023
ranfdev
force-pushed
the
nullable_doc
branch
2 times, most recently
from
dda0782 to
c7c727d
Compare
sdroege
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the issue #932.
I'm not sure if types created with
glib::Enumcan benullable...