Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gir cleanup #171

Merged
merged 10 commits into from
Jan 25, 2021
Merged

gir cleanup #171

merged 10 commits into from
Jan 25, 2021

Conversation

bilelmoussaoui
Copy link
Member

  • remove unused/removed stuff
  • use manual instead of ignore when documented already. The idea is to reduce the usage of ignore & document all the manual stuff

@bilelmoussaoui
gsk: use manual instead of ignore
1408d53
@bilelmoussaoui
gtk: gir cleanup
3ad58f1 
mostly remove the removed functions related stuff
& use manual instead of ignore
@bilelmoussaoui bilelmoussaoui force-pushed the bilelmoussaoui/gir-cleanup branch 7 times, most recently from afbabff to 9becbd8 Compare January 24, 2021 00:22
sdroege
sdroege reviewed Jan 24, 2021
View reviewed changes
gtk4/src/drop_target.rs Outdated Show resolved Hide resolved
sdroege
sdroege reviewed Jan 24, 2021
View reviewed changes
gtk4/src/auto/entry_buffer.rs
@@ -64,16 +64,6 @@ pub trait EntryBufferExt: 'static {
#[doc(alias = "gtk_entry_buffer_emit_inserted_text")]
fn emit_inserted_text(&self, position: u32, chars: &str, n_chars: u32);

fn get_property_length(&self) -> u32;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do these all disappear?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because there are manual version of them, somehow marking them as ignore didn't actually ignore them?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems like a bug in gir :)

sdroege
sdroege reviewed Jan 24, 2021
View reviewed changes
Copy link
Member

@sdroege sdroege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me apart from those comments

@bilelmoussaoui bilelmoussaoui mentioned this pull request Jan 25, 2021
Open
@bilelmoussaoui bilelmoussaoui force-pushed the bilelmoussaoui/gir-cleanup branch from 9becbd8 to af04abe Compare January 25, 2021 12:57
@bilelmoussaoui
Copy link
Member Author

I opened #173 to fix an issue in EntryBuffer subclassing I noticed from working on this one. I will go ahead and merge this one

@bilelmoussaoui bilelmoussaoui merged commit 50d02eb into master Jan 25, 2021
@bilelmoussaoui bilelmoussaoui deleted the bilelmoussaoui/gir-cleanup branch January 25, 2021 13:26
alatiera pushed a commit to alatiera/gtk4-rs that referenced this pull request Apr 10, 2021
@sdroege
Merge pull request gtk-rs#171 from sdroege/get-type-versions
6e7054f 
Add correct versions for get_type functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdroege sdroege sdroege left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bilelmoussaoui @sdroege