Add method to change lamdba event to KCL record #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindseydew
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This adds a method to translate the type returned from the lambda event record to the object type that the kinesis client library is expecting.
As of version 3.0.0 of aws-lambda-java-events reading records from the lambda event returns a different model to the one that the kinesis client library deaggregation method is expecting.
According to the amazon docs we should be importing a custom deaggregation library for running in a lambda. However, the library is not officially supported by AWS and the version we require is not available on maven. See this issue for more information.
I think this approach is our best option to enable us to be able to upgrade aws libraries
How to test
Tested on CODE that publishing an article in CAPI results in log statement produced in the
notificationapp which says:ContentNotificationHow can we measure success?
Have we considered potential risks?
Images
Accessibility