Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show full timestamp for message last updated time #32

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

philmcmahon
Copy link
Collaborator

@philmcmahon philmcmahon commented Feb 20, 2025

Description

This change modifies the securedrop UI so that the time of the most recent message sent by the source is shown in the UI (as opposed to just the month an the day).

There's quite a bit of prior discussion on whether this is a good idea or not - see the issues below for furth details. From the guardian's perspective, we think having the time is extremely valuable when working in a multi user environment

Replaces #11 and is related to:

It looks like this:
shot

Test Plan

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:

  • I have updated the AppArmor profile
  • No update to the AppArmor profile is required for these changes
  • I don't know and would appreciate guidance

If these changes modify the database schema, you should include a database migration. Please check as applicable:

  • I have written a migration and upgraded a test database based on main and confirmed that the migration is self-contained and applies cleanly
  • I have written a migration but have not upgraded a test database based on main and would like the reviewer to do so
  • I need help writing a database migration
  • No database schema changes are needed

@philmcmahon philmcmahon marked this pull request as ready for review February 20, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant