Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to more SDK-style and latest NuGetizer #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kzu
Copy link

@kzu kzu commented Jun 3, 2017

Changes include:

  • Adding the empty dependency groups via the built-in supported mechanism
    in NuGetizer (<PackageFile Kind=Dependency Id=_._)
  • Replacing usage of packages.config for PackageReference in both projects
  • Adding NuGet restore workaround for VS2017 Version 15.3.0 Preview 2.0 [26530.1.d15rel]
    where it's broken right now (see Building a new enlistment fails NuGet/Home#5300)

Changes include:
- Adding the empty dependency groups via the built-in supported mechanism
  in NuGetizer (`<PackageFile Kind=Dependency Id=_._`)
- Replacing usage of packages.config for PackageReference in both projects
- Adding NuGet restore workaround for VS2017 Version 15.3.0 Preview 2.0 [26530.1.d15rel]
  where it's broken right now (see NuGet/Home#5300)
@kzu
Copy link
Author

kzu commented Jun 3, 2017

FWIW, I tried the resulting nuget package on iOS and Android apps and no prompts were raised.

@migueldeicaza
Copy link
Collaborator

Hello! Just wanted to confirm: this works with the released products right now? I would not want to rely on the upcoming preview for it.

@kzu
Copy link
Author

kzu commented Jun 3, 2017

As almost always, it depends ;).

Users can use any VS that supports the NETStandard you're producing, just like the previous hardcoded nuspec had.

building the nuget package requires VS 15.3 to "just work" (i.e. msbuild /t:restore && msbuild /t:build;pack). But VS 15.2 will work if you pass a dummy value via a property or envvar, named NuGetBuildTasksPackTarget, as noted in the friendly error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants