Fixes #3918 and #3913 - Accepting behavior
#3921
Conversation
tig
changed the title
Accepting behavior
There was a problem hiding this comment.
Hmn, so do I understand correctly that it is a new requirement for all button click handlers is for user to e.cancel in the handler? Otherwise any default buttons nearby may get click handler (now called Accepting) called?
We should double check there are no IsDefault issues with our existing dialogs like MessageBox and the Query one - if they have defaults we will need this new esc bit
I also think this is going to be confusing for new users. But happy to merge and see how it goes.
|
I agree with @tznind. This will be confusing for new users. My suggestion is to add a new event called |
Correct. Note, previously,
I already did this when I implemented all this.
The crux of this is the making Things are now super consistent and deterministic, but there IS a bit of mental load required to "get it". I'm happy to discuss ways of mitigating this. Thots:
Others? |
* Moved scripts * testing versions * Rune extensions micro-optimizations (#3910) * Add benchmarks for potentially optimizable RuneExtensions * Add new RuneExtensions.DecodeSurrogatePair benchmark implementation Avoids intermediate heap array allocations which is especially nice when the rune is not surrogate pair because then array heap allocations are completely avoided. * Enable nullable reference types in RuneExtensions * Make RuneExtensions.MaxUnicodeCodePoint readonly Makes sure no one can accidentally change the value. Ideally would be const value. * Optimize RuneExtensions.DecodeSurrogatePair * Remove duplicate Rune.GetUnicodeCategory call * Add new RuneExtensions.IsSurrogatePair benchmark implementation Avoids intermediate heap allocations by using stack allocated buffer. * Optimize RuneExtensions.IsSurrogatePair * Add RuneExtensions.GetEncodingLength tests * Optimize RuneExtensions.GetEncodingLength * Optimize RuneExtensions.Encode * Print encoding name in benchmark results * Rename variable to better match return description * Add RuneExtensions.EncodeSurrogatePair benchmark --------- Co-authored-by: Tig <[email protected]> * Reduce func allocations (#3919) * Replace Region.Contains LINQ lambdas with foreach loop Removes the lambda func allocations caused by captured outer variables. * Replace LineCanvas.Has LINQ lambda with foreach loop * Fix LineCanvas.GetMap intersects array nullability It should be enough to add null-forgiving operator somewhere in the LINQ query to make the final result non-null. No need to shove the nullability further down the line to complicate things. :) * Replace LineCanvas.All LINQ lambda with foreach loop * Replace Region.Intersect LINQ lambdas and list allocation with foreach loop and rented array * Use stackalloc buffer in Region.Intersect when max 8 rectangles * Fix LineCanvas.GetCellMap intersects array nullability * Remove leftover LineCanvas.GetRuneForIntersects null-conditional operators * Remove leftover IntersectionRuneResolver.GetRuneForIntersects null-conditional operators * PosAlign.CalculateMinDimension: calculate sum during loop No need to first put the dimensions in a list and then sum the list when you can just add to sum while looping through dimensions. * PosAlign.CalculateMinDimension: Remove intermediate list and related filter func allocation * TextFormatter.GetRuneWidth: Remove intermediate list and related sum func allocation * ReadOnlySpan refactor preparation for GetCellMap rewrite * LineCanvas.GetCellMap: Reuse intersection list outside nested loops GetCellMap would not benefit much from array pool because IntersectionDefinition is not struct. This change eliminates majority of the rest of Func<,> allocations. As a bonus IntersectionDefinition[] allocations dropped nicely. * Refactor local method UseRounded * Wrap too long list of method parameters * Region: Consistent location for #nullable enable --------- Co-authored-by: Tig <[email protected]> * Fixes #3918 and #3913 - `Accepting` behavior (#3921) * Fixed #3905, #3918 * Tweaked Generic * Label code cleanup * Clean up. * Clean up. * Clean up2. * Fixes #3839, #3922 - CM Glyphs not working (#3923) * fixed * Moved Glyphs to ThemeScope * Removed test code * Fixed nav (#3926) * Fixes #3881. PositionCursor broke with recent ConsoleDriver changes. (#3927) * Reduce IntersectionType[] allocations (#3924) * Eliminate LineCanvas.Has params array allocation Inline ReadOnlySpan arguments do not incur heap allocation compared to regular arrays. * Allocate once LineCanvas.Exactly corner intersection arrays --------- Co-authored-by: Tig <[email protected]> * API doc updates (#3928) --------- Co-authored-by: Tonttu <[email protected]> Co-authored-by: BDisp <[email protected]>
Fixes
CanFocusproperty is set to false, theAcceptingevent is executed 3 times #3905Proposed Changes/Todos
CanFocusproperty is set to false, theAcceptingevent is executed 3 times #3905 is not actually a bug.Pull Request checklist:
CTRL-K-Dto automatically reformat your files before committing.dotnet testbefore commit///style comments)