Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3964. Null Reference in DoDrawBorderAndPadding #3971

Merged
merged 7 commits into from
Mar 9, 2025

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Mar 8, 2025

Fixes

Proposed Changes/Todos

  • Ensures closing all opened menus that belong to another top when a new modal top is opened.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner March 8, 2025 22:30
@BDisp
Copy link
Collaborator Author

BDisp commented Mar 8, 2025

@tig I need your help to fix the "Edit Me" menu that is drawing when the Dialog is over it, please.

WindowsTerminal_0zuamgvSVJ

@tig
Copy link
Collaborator

tig commented Mar 8, 2025

@BDisp See unit test failures.

@BDisp
Copy link
Collaborator Author

BDisp commented Mar 9, 2025

@BDisp See unit test failures.

Done

@tig tig merged commit e76ec72 into gui-cs:v2_develop Mar 9, 2025
11 checks passed
@BDisp
Copy link
Collaborator Author

BDisp commented Mar 9, 2025

@tig I need your help to fix the "Edit Me" menu that is drawing when the Dialog is over it, please.

WindowsTerminal_0zuamgvSVJ

This is already fixed in this PR.

WindowsTerminal_sIuG3XAEXF

@BDisp BDisp deleted the v2_3964_close-all-menus-with-modal-fix branch March 9, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Null Reference in DoDrawBorderAndPadding
2 participants